feat!: Improve session state reliability #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 8, 2024
Closed
|
The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification. |
API Changelog 4.11.1.dev10+gf919a9b6GET /api/v1/sessions
POST /api/v1/sessions
GET /api/v1/sessions/{session_id}
GET /api/v1/users/{user_id}/sessions
|
MoritzWeber0
force-pushed
the
improve-session-state
branch
from
1a855cb to
d0a71b1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
+ Coverage 84.76% 84.78% +0.02%
==========================================
Files 211 211
Lines 6923 6934 +11
Branches 478 482 +4
==========================================
+ Hits 5868 5879 +11
- Misses 890 893 +3
+ Partials 165 162 -3 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
A Storybook preview is available for commit f919a9b. |
MoritzWeber0
force-pushed
the
improve-session-state
branch
from
d0a71b1 to
f319475
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
improve-session-state
branch
from
f319475 to
429aaa5
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
improve-session-state
branch
from
429aaa5 to
ae516a5
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
improve-session-state
branch
from
ae516a5 to
9048b19
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
changed the title
MoritzWeber0
force-pushed
the
improve-session-state
branch
from
9048b19 to
0711948
Compare
This comment has been minimized.
This comment has been minimized.
- Instead of a str, the API returns a fixed set of available states. This makes handling in other application and the frontend easier. - A separate attribute "preparation_state" is returned, indicating the status of the session preparation. - Sessions no longer spawn deployments, Pods are directly created instead. This avoids unwanted restarts of containers. - The `app` label on workloads has been replaced with `capellacollab/session-id` - The logs are no longer considered for the session state. BREAKING CHANGE: Sessions created before this update can't be terminated anymore! Make sure to terminate all sessions before the update or clean the objects in Kubernetes manually.
MoritzWeber0
force-pushed
the
improve-session-state
branch
from
0711948 to
6074fe6
Compare
|
|
This report was generated by comparing f919a9b with b6f1bf2. ArtifactName:
|
| item | count |
|---|---|
| pass | 308 |
| change | 14 |
| new | 20 |
| delete | 28 |
📝 Report
Differences
Session Components_Active Sessions_Session Shared With User_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Shared With User_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session With Feedback Enabled_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session With Feedback Enabled_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Session Overview_All Selected_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Session Overview_Loading_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Session Overview_Loading_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Session Overview_No Sessions_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Session Overview_No Sessions_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Session Overview_Overview_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
New Items
Session Components_Active Sessions_Loading_desktop.png
 |
Session Components_Active Sessions_Loading_mobile.png
 |
Session Components_Active Sessions_Readonly Session Success State_desktop.png
 |
Session Components_Active Sessions_Readonly Session Success State_mobile.png
 |
Session Components_Active Sessions_Session Failed State_desktop.png
 |
Session Components_Active Sessions_Session Failed State_mobile.png
 |
Session Components_Active Sessions_Session Not Found State_desktop.png
 |
Session Components_Active Sessions_Session Not Found State_mobile.png
 |
Session Components_Active Sessions_Session Pending State_desktop.png
 |
Session Components_Active Sessions_Session Pending State_mobile.png
 |
Session Components_Active Sessions_Session Preparation Pending State_desktop.png
 |
Session Components_Active Sessions_Session Preparation Pending State_mobile.png
 |
Session Components_Active Sessions_Session Preparation Running State_desktop.png
 |
Session Components_Active Sessions_Session Preparation Running State_mobile.png
 |
Session Components_Active Sessions_Session Running State_desktop.png
 |
Session Components_Active Sessions_Session Running State_mobile.png
 |
Session Components_Active Sessions_Session Terminated State_desktop.png
 |
Session Components_Active Sessions_Session Terminated State_mobile.png
 |
Session Components_Active Sessions_Session Unknown State_desktop.png
 |
Session Components_Active Sessions_Session Unknown State_mobile.png
 |
Deleted Items
Session Components_Active Sessions_Loading Story_desktop.png
 |
Session Components_Active Sessions_Loading Story_mobile.png
 |
Session Components_Active Sessions_Readonly Session Success State Story_desktop.png
 |
Session Components_Active Sessions_Readonly Session Success State Story_mobile.png
 |
Session Components_Active Sessions_Session Error State Story_desktop.png
 |
Session Components_Active Sessions_Session Error State Story_mobile.png
 |
Session Components_Active Sessions_Session Failed Scheduling State Story_desktop.png
 |
Session Components_Active Sessions_Session Failed Scheduling State Story_mobile.png
 |
Session Components_Active Sessions_Session Killing State Story_desktop.png
 |
Session Components_Active Sessions_Session Killing State Story_mobile.png
 |
Session Components_Active Sessions_Session Network Issues State Story_desktop.png
 |
Session Components_Active Sessions_Session Network Issues State Story_mobile.png
 |
Session Components_Active Sessions_Session Pulled State Story_desktop.png
 |
Session Components_Active Sessions_Session Pulled State Story_mobile.png
 |
Session Components_Active Sessions_Session Pulling State Story_desktop.png
 |
Session Components_Active Sessions_Session Pulling State Story_mobile.png
 |
Session Components_Active Sessions_Session Queued State Story_desktop.png
 |
Session Components_Active Sessions_Session Queued State Story_mobile.png
 |
Session Components_Active Sessions_Session Scheduled State Story_desktop.png
 |
Session Components_Active Sessions_Session Scheduled State Story_mobile.png
 |
Session Components_Active Sessions_Session Stopped State Story_desktop.png
 |
Session Components_Active Sessions_Session Stopped State Story_mobile.png
 |
Session Components_Active Sessions_Session Success State Story_desktop.png
 |
Session Components_Active Sessions_Session Success State Story_mobile.png
 |
Session Components_Active Sessions_Session Unknown State Story_desktop.png
 |
Session Components_Active Sessions_Session Unknown State Story_mobile.png
 |
Session Components_Active Sessions_Session Warning State Story_desktop.png
 |
Session Components_Active Sessions_Session Warning State Story_mobile.png
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Sessions created before this update can't be terminated after the update anymore! Make sure to terminate all sessions before the update or clean the objects in Kubernetes manually.
applabel on workloads has been replaced withcapellacollab/session-id